HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

Add Ruff Rule A* (names shadowing builtins) #957

Closed steven-murray closed 1 month ago

steven-murray commented 1 month ago

This should only be merged after #956

This adds rules that check for names shadowing python built-ins.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.27%. Comparing base (a0b3292) to head (0ed2783).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #957 +/- ## ======================================= Coverage 97.27% 97.27% ======================================= Files 31 31 Lines 10950 10950 ======================================= Hits 10652 10652 Misses 298 298 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/957/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `97.27% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.