search

HERA-Team / hera_mc

The HERA monitor and control (M&C) system.
BSD 2-Clause "Simplified" License
3 stars 3 forks source link

change dir name to docs and edit README for that #588

Closed david-deboer closed 2 years ago

david-deboer commented 2 years ago

For naming convenience, changed Docs sub-directory name to docs.

codecov[bot] commented 2 years ago

Codecov Report

Merging #588 (f5e3f42) into main (b618805) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          35       35           
  Lines        5110     5110           
=======================================
  Hits         4996     4996           
  Misses        114      114
Impacted Files Coverage Δ
hera_mc/cm_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b618805...f5e3f42. Read the comment docs.

bhazelton commented 2 years ago

It looks like this is somehow dropping coverage for line 1426 of correlator.py. I don't really understand why that would be. @david-deboer I think this is code you wrote, any insight?

david-deboer commented 2 years ago

The tests must be using the production version of redis. Recall we are running on a branch for hera_corr_cm with the new implementation, which must change the id format such that it doesn't produce the same list.