HERA-Team / hera_mc

The HERA monitor and control (M&C) system.

BSD 2-Clause "Simplified" License

3 stars 3 forks source link

Add snap mini corr #603

Closed mkolopanis closed 2 years ago

mkolopanis commented 2 years ago

Adds a mini data catcher script to save snap spectra to a UVH5 file.

Description

Reads the status:snap:* keys in redis and compiles them into a UVData object to save to disk.

Motivation and Context

Danny asked for this.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Schema change (any change to the SQL tables)
[ ] New feature without schema change (non-breaking change which adds functionality)
[ ] Change associated with a change in redis structure
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Version change
[ ] Build or continuous integration change
[x] Other

Checklist:

Other:

[x] My code follows the code style of this project.
[x] I understand the updates required onsite (detailed in the readme) and I will make those changes when this is merged.
[x] Unit tests pass on site (This is a critical check, CI can differ from site).
[ ] I have updated the CHANGELOG.

codecov[bot] commented 2 years ago

Codecov Report

Merging #603 (08805bd) into main (0844b22) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files          35       35           
  Lines        5090     5090           
=======================================
  Hits         4994     4994           
  Misses         96       96

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0844b22...08805bd. Read the comment docs.

mkolopanis commented 2 years ago

@bhazelton I think this is worth a look. I'm open to any ideas.

we still have a problem were sometimes while loop thinks it is ready to trigger but only after 200ms. I think this is due to how snap spectra only update on a ~10 min timescale and even then only roll out in stages.