Fix the logic for determining the commanded array source - Githubissues

HERA-Team / hera_notebook_templates

Repository for HERA analysis / real-time pipeline notebooks and related support code

MIT License

0 stars 0 forks source link

Fix the logic for determining the commanded array source #26

Closed bhazelton closed 2 years ago

bhazelton commented 2 years ago

This fixes the logic around the commanded signal source:

Use the proper table (array_signal_source) for the commanded source.
Look up to 3 hours before the files start to get the commanded state because this is usually set well before the data taking begins. Also detect any changes in the commanded source during observing.
Differentiate between antennas reporting as being in the correct state (using the reported FEM switch) and the observed antennas in the correct state. NOTE: this is supposed to add a line in the report, not sure if it is handled properly.

Still to do:

[ ] fix logic for observed antennas in the correct state to account for digital noise

review-notebook-app[bot] commented 2 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jsdillon commented 2 years ago

FYI @bhazelton @dstorer fixed a bug in this: https://github.com/HERA-Team/hera_notebook_templates/commit/c7e3123417779075a9a7cb9aa662605d69087e51

bhazelton commented 2 years ago

oh dear, sorry about that!

jsdillon commented 2 years ago

(re-running now to see if that was the only issue)

jsdillon commented 2 years ago

Found another bug: https://github.com/HERA-Team/hera_notebook_templates/commit/b319602c8e76df42618e6fedb6048672746c902f

jsdillon commented 2 years ago

And another: c21c8f72a7143f1ad2c3f90045dd3d06985ad08d