Switch test suite to pytest

HERA-Team / hera_pspec

HERA power spectrum estimation code and data formats

http://hera-pspec.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

4 stars 3 forks source link

Switch test suite to pytest #312

Closed philbull closed 3 years ago

philbull commented 3 years ago

Converts the existing unit tests to use pytest instead of nosetests.

philbull commented 3 years ago

See #306 and #308

philbull commented 3 years ago

Note that the behaviour of hera_pspec.pspecdata.trim_dset_lsts() has now changed; a ValueError is now raised if the datasets aren't aligned.

philbull commented 3 years ago

Now addresses #280 and #288

review-notebook-app[bot] commented 3 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

nkern commented 3 years ago

@philbull @saurabh-astro update on the problem with the unittest for trim_dset_lsts:

turns out there was a bug in the old test: 50 is the right number, but it was being checked as assert_true(Ntimes, 52), which returns True b/c both are non-zero, not because they are equal.

nkern commented 3 years ago

@philbull lets wait to merge until @saurabh-astro lets us know if he has any further comments on this--also macos 3.8 seems to be failing due to an h5py import error--seems like it's github's fault though, not ours?

saurabh-astro commented 3 years ago

@philbull lets wait to merge until @saurabh-astro lets us know if he has any further comments on this--also macos 3.8 seems to be failing due to an h5py import error--seems like it's github's fault though, not ours?

Great, thanks Nick! I have gone through rest of the changes, and it all seems fine to me. Good to go @philbull!