HERA-Team / hera_pspec

HERA power spectrum estimation code and data formats
http://hera-pspec.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Change clip value in `average_spectra` and elsewhere to be smaller. #334

Closed aewallwi closed 3 years ago

aewallwi commented 3 years ago

1e40 is not a large enough upper bound clip value for calculating upper bounds on weighted error bars since we routinely take (> 1e10 mK^2 Mpc^3)^-4 when we calculate averaged error bars when inverse variance weighting and leads to confusing artifacts.

https://github.com/HERA-Team/hera_pspec/blob/b3f5ae4ab3886dc0238e0cb34a83868eb0d6d0b6/hera_pspec/grouping.py#L394

This issue might be coming up elsewhere and we might want to revisit the clipping across average_spectra.