HERA-Team / hera_pspec

HERA power spectrum estimation code and data formats

http://hera-pspec.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

4 stars 3 forks source link

Fix workflow to run checks at each PR #362

Closed adeliegorce closed 2 years ago

adeliegorce commented 2 years ago

PR to make sure all checks are now running when someone starts a PR...

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@f3cb63f). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage        ?   95.80%           
=======================================
  Files           ?       17           
  Lines           ?     6055           
  Branches        ?        0           
=======================================
  Hits            ?     5801           
  Misses          ?      254           
  Partials        ?        0

Flag	Coverage Δ
unittests	`95.80% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3cb63f...ac901ac. Read the comment docs.

adeliegorce commented 2 years ago

Here are some details on the changes made:

The checks were not running because .github/workflows/ci.yml referred to the master branch instead of main
The version module has been largely modified by a previous PR and does not contain the attribute git_hash anymore. I have replaced the occurrences of version.git_hash by __version__ while ensuring backward compatibility with a try statement (note: git_hash was called when saving history strings in UVPSpec objects)
The required dependencies (pyuvdata, hera_cal, uvtools) are now installed directly with, e.g., pip install hera_calibration instead of calling their git repository.