Closed adeliegorce closed 1 year ago
Base: 95.98% // Head: 95.98% // No change to project coverage :thumbsup:
Coverage data is based on head (
5bbc0ba
) compared to base (dcba4d4
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@steven-murray it seems like the tests are failing because of the latest version of hera_cal
(I tried with the PyPi distribution and the main
branch of the repo)... Any idea what changed?
If you want to have a look, the error is triggered when running pytest test_grouping.py
in hera_pspec
and comes from a ValueError
in hera_cal/utils.py
@adeliegorce hmm I see. I made https://github.com/HERA-Team/hera_cal/pull/864 to try and fix this.
@adeliegorce can you try running these tests on the new branch of hera_cal -- that'll help us know if that branch actually fixes the problem.
There is another ValueError
. I am having some trouble tracing it back but it seems like hera_cal.io.load_vis
outputs arrays of a different shape than it used to. Does that make sense considering you've modified hera_cal.utils.lst_rephase
?
Okay it has to be related because the method failing is pspecdata.rephase_to_dset
This PR includes new doc files to account for the new possibility to install
hera_pspec
directly from PyPi:README
has been updated from Markdown to ReStructuredText (RST) which is more easily read by PyPiInstallation
section has been added.