HERA-Team / hera_pspec

HERA power spectrum estimation code and data formats
http://hera-pspec.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Doc files for PyPi installation #370

Closed adeliegorce closed 1 year ago

adeliegorce commented 1 year ago

This PR includes new doc files to account for the new possibility to install hera_pspec directly from PyPi:

codecov[bot] commented 1 year ago

Codecov Report

Base: 95.98% // Head: 95.98% // No change to project coverage :thumbsup:

Coverage data is based on head (5bbc0ba) compared to base (dcba4d4). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #370 +/- ## ======================================= Coverage 95.98% 95.98% ======================================= Files 17 17 Lines 6046 6046 ======================================= Hits 5803 5803 Misses 243 243 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `95.98% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

adeliegorce commented 1 year ago

@steven-murray it seems like the tests are failing because of the latest version of hera_cal (I tried with the PyPi distribution and the main branch of the repo)... Any idea what changed? If you want to have a look, the error is triggered when running pytest test_grouping.py in hera_pspec and comes from a ValueError in hera_cal/utils.py

steven-murray commented 1 year ago

@adeliegorce hmm I see. I made https://github.com/HERA-Team/hera_cal/pull/864 to try and fix this.

steven-murray commented 1 year ago

@adeliegorce can you try running these tests on the new branch of hera_cal -- that'll help us know if that branch actually fixes the problem.

adeliegorce commented 1 year ago

There is another ValueError. I am having some trouble tracing it back but it seems like hera_cal.io.load_vis outputs arrays of a different shape than it used to. Does that make sense considering you've modified hera_cal.utils.lst_rephase?

adeliegorce commented 1 year ago

Okay it has to be related because the method failing is pspecdata.rephase_to_dset