HERA-Team / hera_pspec

HERA power spectrum estimation code and data formats
http://hera-pspec.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Check spws up front #371

Closed steven-murray closed 1 year ago

steven-murray commented 1 year ago

Just checks that input spw's to the pspec_run function are valid, before reading too much stuff in, and print out helpful info if it fails.

steven-murray commented 1 year ago

@adeliegorce that was my first thought as well, and maybe that's the right thing to do (I don't know hera_pspec well). However, I changed my mind and put it in pspec_run because if it's in pspec it's already done a bunch of stuff and taken a while before you know that things are wrong. It turns out to be easy to get the spws wrong from makeflow because you previously select other spws that can conflict with the pspec ones.

codecov[bot] commented 1 year ago

Codecov Report

Base: 95.98% // Head: 95.98% // No change to project coverage :thumbsup:

Coverage data is based on head (dcba4d4) compared to base (dcba4d4). Patch has no changes to coverable lines.

:exclamation: Current head dcba4d4 differs from pull request most recent head 468261d. Consider uploading reports for the commit 468261d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #371 +/- ## ======================================= Coverage 95.98% 95.98% ======================================= Files 17 17 Lines 6046 6046 ======================================= Hits 5803 5803 Misses 243 243 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `95.98% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

adeliegorce commented 1 year ago

Okay, makes sense!