search

HERA-Team / hera_pspec

HERA power spectrum estimation code and data formats
http://hera-pspec.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Changed test beamfile to have only float data #374

Closed adeliegorce closed 1 year ago

adeliegorce commented 1 year ago

Had to modify a beam file used in tests because the data_array was filled with complex numbers, which pyuvdata does not support anymore (release 2.2.12). If tests are still failing, it is because of the future array shapes in pyuvdata. With this PR, the tests triggering the error ValueError: UVParameter _data_array is not the appropriate type. Is: <class 'complex'>. Should be: <class 'float'>. are fixed but the ValueError: non-broadcastable output operand remain.

steven-murray commented 1 year ago

@adeliegorce I merged the fix for the hera_cal stuff, but this branch looks like it's still failing the pyuvdata stuff?

adeliegorce commented 1 year ago

It is failing because there is a requirement pyuvdata<=2.2.8. At this time pyuvdata wanted complex data arrays for beams but newer versions require float data arrays. Runs are passing locally without this PR and with the updated hera_cal. Not sure why it was failing before?

steven-murray commented 1 year ago

@adeliegorce ah I see. You probably have a newer version of pyuvdata locally, which works with this. Let's relieve the version of pyuvdata on the branch and see...

codecov[bot] commented 1 year ago

Codecov Report

Base: 95.98% // Head: 95.98% // No change to project coverage :thumbsup:

Coverage data is based on head (418a260) compared to base (5275bd5). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #374 +/- ## ======================================= Coverage 95.98% 95.98% ======================================= Files 17 17 Lines 6053 6053 ======================================= Hits 5810 5810 Misses 243 243 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `95.98% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.