Closed adeliegorce closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.04
:tada:
Comparison is base (
a6ea0a4
) 95.95% compared to head (68d0995
) 95.99%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This looks good and is very timely -- we're actively working on pyuvdata 3.0 where we will remove support for the old shapes. One thing I wanted to mention is that we now have quite good support for spectral windows. Each frequency is assigned to a spectral window using the flex_spw_id_array
on UVData and UVCal objects. I know that pspec uses spectral windows, so I wanted to highlight this in case it was useful to you.
One thing I wanted to mention is that we now have quite good support for spectral windows. Each frequency is assigned to a spectral window using the
flex_spw_id_array
on UVData and UVCal objects. I know that pspec uses spectral windows, so I wanted to highlight this in case it was useful to you.
Hi @bhazelton, thanks for the comments! I think this PR is a good occasion to discuss the structure of UVPSpec
objects - but might be beyond its scope. We'll keep this feature in mind when doing the large-scale review of the code in the fall :)
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
This PR makes
hera_pspec
compatible with the new version ofUVData
usingfuture_array_shapes
(i.e.spw
is no longer an axis in data arrays) whilst remaining compatible with olderUVPspec
objects that could be read. Main features are:UVData
,UVCal
andUVBeam
objects are now read in with thefuture_array_shapes
option. When converted in aPSpecBeam
orPSpecData
object, the resulting object is (mostly) unchanged (see below).UVData
behaviour, nowPSpecData
objects have an array ofchannel_width
instead of a single value. This will be (most of the time)Nfreqs
times the same value. All tests pass. Let me know if you want to discuss additional features or find bugs - this is very basic.