HERA-Team / hera_pspec

HERA power spectrum estimation code and data formats
http://hera-pspec.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Fixing pspec_run to allow the use of non-future-array-shape uvdata #387

Closed JianrongTan closed 11 months ago

JianrongTan commented 1 year ago

Currently the pspec_run command accepts dsets as a parameter, which is a list of UVData objects or string filepaths to UVData-compatible files. However, the acceptable UVData objects are implicitly using future_array_shape, which is not specified in the code. This PR aims to fix this issue.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b5cbc4c) 95.99% compared to head (fac41f1) 95.99%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #387 +/- ## ======================================= Coverage 95.99% 95.99% ======================================= Files 17 17 Lines 6113 6113 ======================================= Hits 5868 5868 Misses 245 245 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_pspec/pull/387/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_pspec/pull/387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `95.99% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/HERA-Team/hera_pspec/pull/387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_pspec/pspecdata.py](https://app.codecov.io/gh/HERA-Team/hera_pspec/pull/387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9wc3BlYy9wc3BlY2RhdGEucHk=) | `97.05% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JianrongTan commented 1 year ago

Thanks @adeliegorce! I see docs/readthedocs.org:hera-pspec — Read the Docs build failed! in the checks. Is this a problem I should fix before merging and how should I do that?

adeliegorce commented 1 year ago

Ah, that's new... I'll have a look.

adeliegorce commented 1 year ago

OK @JianrongTan, this is a problem completely independent from your PR (as expected). So if your PR is very urgent, please go ahead and merge it. If not, keep an eye on PR#388 which solves the issue (awaiting approval) :)

adeliegorce commented 11 months ago

Hi @JianrongTan, the PR is all approved and ready to be merged!