Closed adeliegorce closed 6 months ago
To whoever reviews this PR, a question: why is there a list of requirements for docs
in setup.cfg
and a docs/requirements.txt
file? it seems like the latter overruns the former? thanks
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
fac41f1
) 95.99% compared to head (7f4d549
) 95.99%. Report is 7 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @steven-murray, thanks for the review. I have made the requested changes apart from switching to codecov-actions@v4
as there is a regression issue. Let's keep it in mind (or create an issue related to this) and do the update in a couple months once things are more stable.
This PR adds two elements that were missing for the tests to pass:
codecov
. Although it is not required for public repos, uploads often fail when you don't have one. If you don't set one, it uses like a backup public token which has a rate limit (@steven-murray)mock
package as a requirement for the documentation: buildingreadthedocs
is failing without (called inconf.py
)