Lack of backward compatibility for non-future_array_shape in utils.uvd_to_Tsys

HERA-Team / hera_pspec

HERA power spectrum estimation code and data formats

http://hera-pspec.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

5 stars 3 forks source link

Lack of backward compatibility for non-future_array_shape in utils.uvd_to_Tsys #396

Closed JianrongTan closed 5 months ago

JianrongTan commented 6 months ago

In utils.uvd_to_Tsys, this line doesn't work if uvd is not using future_array_shape

uvd.data_array[tinds, :, pind] *= J2K[pol]

adeliegorce commented 6 months ago

Thank you for pointing this out. This issue is addressed in PR#397.

adeliegorce commented 6 months ago

@JianrongTan @lisaleemcb could you re-run your pipeline in the future-array-shapes-bug branch and let me know if the changes I made fixed your issue?

JianrongTan commented 5 months ago

Thanks @adeliegorce! I have tested with the updated code and the issue is solved.

adeliegorce commented 5 months ago

Great! Could you review the associated PR?