search

HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

xrfi_run with no z-scores #372

Closed aewallwi closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #372 into master will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
+ Coverage   97.02%   97.04%   +0.01%     
==========================================
  Files           8        8              
  Lines        3060     3076      +16     
==========================================
+ Hits         2969     2985      +16     
  Misses         91       91
Impacted Files Coverage Δ
hera_qm/utils.py 96.99% <100.00%> (+0.13%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18e1741...2a39da5. Read the comment docs.

jsdillon commented 4 years ago

Sorry to butt in here, but this seems like it should be an option with xrfi_run.py and not an entirely new script. We've got an over-proliferation of scripts here which makes the codebase harder to maintain and I actually think we should be eliminating some of the older, unused ones (also some of the legacy XRFI functions).