search

HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Fix definition of modified z-score in auto_metrics #394

Closed jsdillon closed 3 years ago

jsdillon commented 3 years ago

I was multiplying by 1.4826 instead of dividing by 1.4826. So all the modified z-scores in previous calculations were off by a factor of ~2. This fixes that bug and changes the defaults to reflect that change.

codecov[bot] commented 3 years ago

Codecov Report

Merging #394 (c7c3e03) into master (46730a3) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files           9        9           
  Lines        3258     3258           
=======================================
  Hits         3167     3167           
  Misses         91       91
Impacted Files Coverage Δ
hera_qm/auto_metrics.py 100.00% <100.00%> (ø)
hera_qm/utils.py 97.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 46730a3...029b95e. Read the comment docs.