search

HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Fix bug in process_ex_ants #399

Closed jsdillon closed 3 years ago

jsdillon commented 3 years ago

@dstorer noticed an error in the logic of process_ex_ants where if ex_ants is not specified but metrics_files, the result is just an empty list.

This fixes that bug and exposes the error in a unit test.

codecov[bot] commented 3 years ago

Codecov Report

Merging #399 (359c8ce) into master (b1bbfcc) will decrease coverage by 0.00%. The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
- Coverage   97.08%   97.07%   -0.01%     
==========================================
  Files          10       10              
  Lines        3289     3286       -3     
==========================================
- Hits         3193     3190       -3     
  Misses         96       96
Impacted Files Coverage Δ
hera_qm/metrics_io.py 92.14% <86.36%> (-0.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1bbfcc...359c8ce. Read the comment docs.