search

HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Make fixes for numpy v1.20 #401

Closed plaplant closed 3 years ago

plaplant commented 3 years ago

In the upgrade to numpy v1.20, several datatypes like np.int were formally deprecated. This led to the incorrect number of warnings being raised for some hera_qm tests, so they were failing. This PR removes references to the deprecated types, and cleans up some of the tests in the process.

codecov[bot] commented 3 years ago

Codecov Report

Merging #401 (5d24c74) into master (ba19f79) will not change coverage. The diff coverage is 92.59%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   97.08%   97.08%           
=======================================
  Files          10       10           
  Lines        3288     3288           
=======================================
  Hits         3192     3192           
  Misses         96       96
Impacted Files Coverage Δ
hera_qm/vis_metrics.py 95.63% <71.42%> (ø)
hera_qm/metrics_io.py 92.14% <100.00%> (ø)
hera_qm/omnical_metrics.py 98.56% <100.00%> (ø)
hera_qm/xrfi.py 99.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba19f79...5d24c74. Read the comment docs.