HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Rewrite xrfi_run more cleanly and concisely #408

Closed jsdillon closed 2 years ago

jsdillon commented 2 years ago

By changing what's looped over and what's explicitly written out and using a dictionary for repeated kwargs, I've vastly simplified xrfi_run without changing its inputs or outputs. Hopefully, this will make things easier to debug.

codecov[bot] commented 2 years ago

Codecov Report

Merging #408 (06d86e6) into master (d5d91cd) will decrease coverage by 0.03%. The diff coverage is 100.00%.

:exclamation: Current head 06d86e6 differs from pull request most recent head a8f3b78. Consider uploading reports for the commit a8f3b78 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
- Coverage   97.01%   96.98%   -0.04%     
==========================================
  Files          10       10              
  Lines        3317     3280      -37     
==========================================
- Hits         3218     3181      -37     
  Misses         99       99              
Impacted Files Coverage Δ
hera_qm/xrfi.py 99.78% <100.00%> (-0.01%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5d91cd...a8f3b78. Read the comment docs.

jsdillon commented 2 years ago

image

I've run XRFI on both this branch and the master branch for a subset of 2459122 with the same settings used for that day. I get the same results (except in the history field, of course), so I'm feeling pretty confident I haven't introduced any bugs.