search

HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Ant metrics fast reader #420

Closed jsdillon closed 2 years ago

jsdillon commented 2 years ago

This PR migrates ant_metrics over to using the new HERADataFastReader, which should improve I/O by a factor of 2 or better.

This PR also gives advanced users the option of using the AntennaMetrics class with only minimal I/O by providing DataContainers directly. This should be useful for interactive work, like the fastcal inspect notebook currently being developed: https://github.com/HERA-Team/hera_notebook_templates/blob/master/notebooks/fastcal_inspect.ipynb

codecov[bot] commented 2 years ago

Codecov Report

Merging #420 (cf4a781) into main (b21d1bc) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   96.90%   96.95%   +0.05%     
==========================================
  Files          10       10              
  Lines        3394     3421      +27     
==========================================
+ Hits         3289     3317      +28     
+ Misses        105      104       -1
Impacted Files Coverage Δ
hera_qm/ant_metrics.py 98.23% <100.00%> (+0.57%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.