HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Add functions for flagging auto-correlations #423

Closed tyler-a-cox closed 1 year ago

tyler-a-cox commented 2 years ago

This PR implements new RFI flagging functions for auto-correlation using channel differencing and DPSS filtering from @AaronParsons fastcal notebook.

codecov[bot] commented 2 years ago

Codecov Report

Merging #423 (5b1ecba) into main (4f82bc5) will increase coverage by 0.00%. The diff coverage is 97.01%.

:exclamation: Current head 5b1ecba differs from pull request most recent head b6169ff. Consider uploading reports for the commit b6169ff to get more accurate results

@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files          10       10           
  Lines        3465     3532   +67     
=======================================
+ Hits         3361     3426   +65     
- Misses        104      106    +2     
Impacted Files Coverage Δ
hera_qm/xrfi.py 99.59% <96.61%> (-0.19%) :arrow_down:
hera_qm/ant_class.py 97.35% <100.00%> (+0.11%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tyler-a-cox commented 2 years ago

Thanks for all of your comments @jsdillon! This should be ready for another look. I also added a function which classifies antennas by their flag fraction relative to the array-wide flag fraction. I added it to xrfi, but a better place for it may be ant_class. Let me know what you think!

tyler-a-cox commented 1 year ago

Thanks for the notes @jsdillon. I think this should be the last time you need to look at this. If I missed anything, let me know!