codecov[bot]
commented
2 years ago Codecov Report
Base: 97.04% // Head: 97.04% // Increases project coverage by +0.00% :tada:
Coverage data is based on head (
335b83d) compared to base (dffdef6). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #428 +/- ## ======================================= Coverage 97.04% 97.04% ======================================= Files 9 9 Lines 3517 3519 +2 ======================================= + Hits 3413 3415 +2 Misses 104 104 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_qm/pull/428?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_qm/ant\_class.py](https://codecov.io/gh/HERA-Team/hera_qm/pull/428/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9xbS9hbnRfY2xhc3MucHk=) | `97.43% <100.00%> (+0.02%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This PR does two things.
First, it fixes a bug where auto_slope_checker fails to classify antennas with all 0s in the data because they yield nans. This classifies them as having slope zero.
Second, and more importantly, this changes the behavior of auto_rfi_checker to look for excess RFI not seen across the whole array, rather than the fraction of the band. In my experiments, I found that the previous method was having a hard time with antennas like the red one near the top here, but looking for an absolute bound on excess RFI does the trick nicely.