search

HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Fix memory leak in ant_metrics by not saving input data to self. #429

Closed jsdillon closed 1 year ago

jsdillon commented 1 year ago

This PR just plumbs through the optional data files, rather than attaching it to the AntennaMetrics class.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.04% // Head: 97.04% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (9ccf1bc) compared to base (1dfcaf5). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #429 +/- ## ========================================== - Coverage 97.04% 97.04% -0.01% ========================================== Files 9 9 Lines 3519 3515 -4 ========================================== - Hits 3415 3411 -4 Misses 104 104 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_qm/pull/429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_qm/ant\_metrics.py](https://codecov.io/gh/HERA-Team/hera_qm/pull/429/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9xbS9hbnRfbWV0cmljcy5weQ==) | `98.21% <100.00%> (-0.03%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.