HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Enable flagging autos for missing RFI #437

Closed jsdillon closed 2 years ago

jsdillon commented 2 years ago

This PR enables the flagging of autocorrelations that don't have enough RFI. In practice, this doesn't flag any more antennas (missing RFI usually means other problems) but I think it'll help distinguish FEM off antennas from other issues.

codecov[bot] commented 2 years ago

Codecov Report

Base: 97.05% // Head: 97.05% // No change to project coverage :thumbsup:

Coverage data is based on head (9d3b8fc) compared to base (7a3ff6f). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #437 +/- ## ======================================= Coverage 97.05% 97.05% ======================================= Files 9 9 Lines 3563 3563 ======================================= Hits 3458 3458 Misses 105 105 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_qm/pull/437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_qm/ant\_class.py](https://codecov.io/gh/HERA-Team/hera_qm/pull/437/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9xbS9hbnRfY2xhc3MucHk=) | `97.59% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.