search

HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Fix macos svd error #444

Closed tyler-a-cox closed 1 year ago

tyler-a-cox commented 1 year ago

PR to fix the MacOS np.linalg.svd convergence issue seen in https://github.com/HERA-Team/hera_qm/pull/443

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fc599c3) 97.09% compared to head (3705dc1) 97.09%.

:exclamation: Current head 3705dc1 differs from pull request most recent head 7d95af4. Consider uploading reports for the commit 7d95af4 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #444 +/- ## ======================================= Coverage 97.09% 97.09% ======================================= Files 11 11 Lines 3540 3540 ======================================= Hits 3437 3437 Misses 103 103 ``` | [Files Changed](https://app.codecov.io/gh/HERA-Team/hera_qm/pull/444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_qm/xrfi.py](https://app.codecov.io/gh/HERA-Team/hera_qm/pull/444?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9xbS94cmZpLnB5) | `99.49% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jsdillon commented 1 year ago

Closed in favor of #445