Closed jsdillon closed 1 year ago
Patch and project coverage have no change.
Comparison is base (
bb60211
) 97.09% compared to head (2a0a8a1
) 97.09%.:exclamation: Current head 2a0a8a1 differs from pull request most recent head 273dfe2. Consider uploading reports for the commit 273dfe2 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks like getting tests passing again was a matter of
1) making sure recent versions of libraries were used 2) changing some tolerances of tests 3) removing a filter step we didn't need
On 2, I'm not completely comfortable with this (feels like cheating to an extent), but since this is for very old XRFI stuff that we're not using anymore and should probably deprecate, I'll just make https://github.com/HERA-Team/hera_qm/issues/446 to remind us to do something about it.