HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Get tests passing again #445

Closed jsdillon closed 1 year ago

jsdillon commented 1 year ago

Looks like getting tests passing again was a matter of

1) making sure recent versions of libraries were used 2) changing some tolerances of tests 3) removing a filter step we didn't need

On 2, I'm not completely comfortable with this (feels like cheating to an extent), but since this is for very old XRFI stuff that we're not using anymore and should probably deprecate, I'll just make https://github.com/HERA-Team/hera_qm/issues/446 to remind us to do something about it.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (bb60211) 97.09% compared to head (2a0a8a1) 97.09%.

:exclamation: Current head 2a0a8a1 differs from pull request most recent head 273dfe2. Consider uploading reports for the commit 273dfe2 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #445 +/- ## ======================================= Coverage 97.09% 97.09% ======================================= Files 11 11 Lines 3540 3540 ======================================= Hits 3437 3437 Misses 103 103 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.