HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Minor speedup to ant_metrics.calc_corr_stats() #448

Closed jsdillon closed 11 months ago

jsdillon commented 11 months ago

I've verified that this produces exactly the same result, but improves ant_metrics runtime by ~25% (~12 seconds on the file I tested to ~9 seconds).

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cd02ad8) 97.09% compared to head (a345e0e) 97.09%.

:exclamation: Current head a345e0e differs from pull request most recent head cfe287e. Consider uploading reports for the commit cfe287e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #448 +/- ## ======================================= Coverage 97.09% 97.09% ======================================= Files 11 11 Lines 3540 3544 +4 ======================================= + Hits 3437 3441 +4 Misses 103 103 ``` | [Files Changed](https://app.codecov.io/gh/HERA-Team/hera_qm/pull/448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_qm/ant\_metrics.py](https://app.codecov.io/gh/HERA-Team/hera_qm/pull/448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9xbS9hbnRfbWV0cmljcy5weQ==) | `99.53% <100.00%> (+<0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.