HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Minor speed-up to x-engine checker #450

Open tyler-a-cox opened 1 year ago

tyler-a-cox commented 1 year ago

This PR makes a couple minor changes to ant_class.non_noiselike_xengine_checker to improve its computational performance. Function now pre-computes the channel width and gives the user the option to pre-compute the integration time. Prior to this change, predict_noise_variance_from_autos would recompute these values for each baseline.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (50af006) 97.09% compared to head (4838a67) 97.09%.

:exclamation: Current head 4838a67 differs from pull request most recent head ee0a08d. Consider uploading reports for the commit ee0a08d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #450 +/- ## ======================================= Coverage 97.09% 97.09% ======================================= Files 11 11 Lines 3544 3551 +7 ======================================= + Hits 3441 3448 +7 Misses 103 103 ``` | [Files Changed](https://app.codecov.io/gh/HERA-Team/hera_qm/pull/450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_qm/ant\_class.py](https://app.codecov.io/gh/HERA-Team/hera_qm/pull/450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9xbS9hbnRfY2xhc3MucHk=) | `97.99% <100.00%> (+0.05%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.