search

HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Update for uvdata3 #453

Closed steven-murray closed 6 months ago

steven-murray commented 6 months ago

Updates code to work for pyuvdata v3+. Mostly this means assuming that the results from _key2inds and antpair2inds are possibly slices, rather than arrays of integers. It also fixes a problem with using pytest.warns(None) which is deprecated in pytest 8, and replaces it with pyuvdata.tests.check_warnings(), which is much simpler anyway.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3e71720) 97.09% compared to head (6728a34) 97.06%.

Files Patch % Lines
hera_qm/xrfi.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #453 +/- ## ========================================== - Coverage 97.09% 97.06% -0.03% ========================================== Files 11 11 Lines 3544 3549 +5 ========================================== + Hits 3441 3445 +4 - Misses 103 104 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

steven-murray commented 6 months ago

@bhazelton note that the missing coverage line will not be missing for pyuvdata 3. It's impossible to cover for pyuvdata 2.