codecov[bot]
commented
6 months ago Codecov Report
Attention: 404 lines in your changes are missing coverage. Please review.
Comparison is base (
84ec3a7) 97.07% compared to head (b28ed11) 82.69%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #455 +/- ## =========================================== - Coverage 97.07% 82.69% -14.39% =========================================== Files 11 25 +14 Lines 3553 4171 +618 =========================================== Hits 3449 3449 - Misses 104 722 +618 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
jsdillon
This pulls all the code out of
setup.pyandsetup.cfgand puts it in the python-preferredpyproject.toml.There should be no change of usage with this PR at all, it's just a more modern way of doing things.
A couple of things to note:
pyproject.tomldoesn't support (AFAIK) installing "scripts" the same way assetup.py. In fact, it's much nicer, supporting the more general concept of "entry points". How these should be used is to have each "script" as a function that can be run without arguments, and thepyproject.tomlspecifies the CLI command to run that function. This can be built into something really nice if you use a CLI builder likeclick. Here, I haven't done anything nice like that -- I just moved the scripts into the main package (so they get installed) and named their CLI command as the script name (including the.pysuffix), so there's no change of usage. I would be happy to update this to be a little more modern, so we'd invoke for example:hera-qm run-xrfietc. But I'll leave that up to people who usehera_qmmore to decide.ruffrules to thepyproject.toml-- these are simply to reflect thepycodestylerules that were in thesetup.cfg. Note that these rules weren't being enforced in anyway -- we don't have pre-commit setup on this repo -- so adding them here is not doing anything yet. I can make another PR that auto-fixes the rules that aren't ignored.