HERA-Team / hera_qm

HERA Data Quality Metrics
MIT License
2 stars 2 forks source link

Enable non_noiselike_diff_by_xengine_checker to also use autos #462

Closed jsdillon closed 6 months ago

jsdillon commented 6 months ago

This fixes a relatively rare problem in RTP where flagging doesn't completely catch every antenna with missing packets because the strongest evidence for problems showed up in the autos (which was excluded for simplicity before). This corrects that oversight.

Here's an example from zen.2460451.16874.sum.uvh5:

image

Before xengine_diff_class

image

After:

image

With fix:

image

I've verified that there's no effect on zen.2460451.34457.sum.uvh5 which was fine.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.10%. Comparing base (75b4b24) to head (23b7cf7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #462 +/- ## ======================================= Coverage 97.10% 97.10% ======================================= Files 11 11 Lines 3597 3598 +1 ======================================= + Hits 3493 3494 +1 Misses 104 104 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.