search

HERA-Team / hera_sim

Simple simulation code for HERA-like redundant interferometric arrays
Other
16 stars 8 forks source link

doc: raise warning on using vispu because of baseline conjugation #182

Closed steven-murray closed 3 years ago

steven-murray commented 3 years ago

Adds a warning whenever using VisCPU, because it doesn't get baseline conjugation right in all cases.

Might be better to specify exactly when it gets it wrong, but hopefully just having the warning will be enough until v2 comes.

codecov[bot] commented 3 years ago

Codecov Report

Merging #182 (de7bd30) into main (3df0ec5) will decrease coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   94.95%   94.91%   -0.04%     
==========================================
  Files          24       24              
  Lines        2753     2755       +2     
==========================================
+ Hits         2614     2615       +1     
- Misses        139      140       +1
Impacted Files Coverage Δ
hera_sim/visibilities/vis_cpu.py 87.66% <100.00%> (-0.50%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf49b78...de7bd30. Read the comment docs.

steven-murray commented 3 years ago

Thanks @r-pascua, that's incredibly helpful. I've updated the warning.

And yes, that test does fail if we don't skip it (see https://github.com/RadioAstronomySoftwareGroup/pyuvsim/pull/363)