search

HERA-Team / hera_sim

Simple simulation code for HERA-like redundant interferometric arrays
Other
16 stars 8 forks source link

Temporary fix for future array shape #216

Closed piyanatk closed 2 years ago

piyanatk commented 2 years ago

pyuvdata switched to using future_array_shapes by default from pyuvdata>=2.7.0. Many functionalities of hera_sim=2.x.x relies on the current_array_shapes (see, e.g., #211). This PR provides a temporary fix to this issue The full fix is planned for hera_sim=3.x.x.

codecov[bot] commented 2 years ago

Codecov Report

Merging #216 (8542daa) into main (0856d83) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   96.56%   96.54%   -0.03%     
==========================================
  Files          24       24              
  Lines        2798     2804       +6     
==========================================
+ Hits         2702     2707       +5     
- Misses         96       97       +1
Impacted Files Coverage Δ
hera_sim/io.py 98.63% <100.00%> (+0.03%) :arrow_up:
hera_sim/visibilities/pyuvsim_wrapper.py 100.00% <100.00%> (ø)
hera_sim/visibilities/simulators.py 85.50% <100.00%> (-0.53%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d19b6ff...8542daa. Read the comment docs.