search

HERA-Team / hera_sim

Simple simulation code for HERA-like redundant interferometric arrays
Other
16 stars 8 forks source link

Mutual coupling fix #248

Closed r-pascua closed 1 year ago

r-pascua commented 1 year ago

This PR updates the mutual coupling simulation routine to correctly use the provided UVBeam objects. See this memo for details.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 1 year ago

Codecov Report

Base: 96.52% // Head: 96.55% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (68db6d9) compared to base (ac9fed1). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #248 +/- ## ========================================== + Coverage 96.52% 96.55% +0.03% ========================================== Files 24 24 Lines 3019 3046 +27 ========================================== + Hits 2914 2941 +27 Misses 105 105 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_sim/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_sim/beams.py](https://codecov.io/gh/HERA-Team/hera_sim/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vYmVhbXMucHk=) | `98.22% <ø> (ø)` | | | [hera\_sim/cli\_utils.py](https://codecov.io/gh/HERA-Team/hera_sim/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vY2xpX3V0aWxzLnB5) | `98.78% <ø> (ø)` | | | [hera\_sim/foregrounds.py](https://codecov.io/gh/HERA-Team/hera_sim/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vZm9yZWdyb3VuZHMucHk=) | `100.00% <ø> (ø)` | | | [hera\_sim/interpolators.py](https://codecov.io/gh/HERA-Team/hera_sim/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vaW50ZXJwb2xhdG9ycy5weQ==) | `97.05% <ø> (ø)` | | | [hera\_sim/io.py](https://codecov.io/gh/HERA-Team/hera_sim/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vaW8ucHk=) | `98.63% <ø> (ø)` | | | [hera\_sim/simulate.py](https://codecov.io/gh/HERA-Team/hera_sim/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vc2ltdWxhdGUucHk=) | `94.72% <ø> (ø)` | | | [hera\_sim/utils.py](https://codecov.io/gh/HERA-Team/hera_sim/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vdXRpbHMucHk=) | `97.07% <ø> (ø)` | | | [hera\_sim/visibilities/healvis\_wrapper.py](https://codecov.io/gh/HERA-Team/hera_sim/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vdmlzaWJpbGl0aWVzL2hlYWx2aXNfd3JhcHBlci5weQ==) | `97.29% <ø> (ø)` | | | [hera\_sim/visibilities/pyuvsim\_wrapper.py](https://codecov.io/gh/HERA-Team/hera_sim/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vdmlzaWJpbGl0aWVzL3B5dXZzaW1fd3JhcHBlci5weQ==) | `100.00% <ø> (ø)` | | | [hera\_sim/visibilities/simulators.py](https://codecov.io/gh/HERA-Team/hera_sim/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vdmlzaWJpbGl0aWVzL3NpbXVsYXRvcnMucHk=) | `85.46% <ø> (ø)` | | | ... and [5 more](https://codecov.io/gh/HERA-Team/hera_sim/pull/248?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.