HERA-Team / hera_sim

Simple simulation code for HERA-like redundant interferometric arrays
Other
16 stars 8 forks source link

H4C Bandpass #251

Closed r-pascua closed 1 year ago

r-pascua commented 1 year ago

This PR adds a model for the H4C bandpass, as well as a tanh tapering function to assist in getting the right rolloff when adding a realistic level of per-antenna perturbations to the base bandpass. This PR also adds a tool for interpolating complex-valued reflection coefficients.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 90.25% and project coverage change: -3.10 :warning:

Comparison is base (7d860d8) 96.04% compared to head (7d58017) 92.95%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #251 +/- ## ========================================== - Coverage 96.04% 92.95% -3.10% ========================================== Files 23 24 +1 Lines 2961 3209 +248 Branches 0 705 +705 ========================================== + Hits 2844 2983 +139 - Misses 117 123 +6 - Partials 0 103 +103 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `92.92% <89.89%> (-3.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_sim/adjustment.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vYWRqdXN0bWVudC5weQ==) | `99.48% <ø> (-0.52%)` | :arrow_down: | | [hera\_sim/utils.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vdXRpbHMucHk=) | `91.71% <80.00%> (-2.38%)` | :arrow_down: | | [hera\_sim/visibilities/vis\_cpu.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vdmlzaWJpbGl0aWVzL3Zpc19jcHUucHk=) | `84.78% <83.05%> (-8.13%)` | :arrow_down: | | [hera\_sim/sigchain.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vc2lnY2hhaW4ucHk=) | `93.09% <87.50%> (-4.90%)` | :arrow_down: | | [hera\_sim/visibilities/simulators.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vdmlzaWJpbGl0aWVzL3NpbXVsYXRvcnMucHk=) | `80.31% <92.59%> (+1.48%)` | :arrow_up: | | [hera\_sim/visibilities/cli.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vdmlzaWJpbGl0aWVzL2NsaS5weQ==) | `92.96% <92.96%> (ø)` | | | [hera\_sim/interpolators.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vaW50ZXJwb2xhdG9ycy5weQ==) | `93.96% <95.45%> (-3.10%)` | :arrow_down: | | [hera\_sim/beams.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vYmVhbXMucHk=) | `97.73% <100.00%> (-0.91%)` | :arrow_down: | | [hera\_sim/cli\_utils.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vY2xpX3V0aWxzLnB5) | `93.97% <100.00%> (-4.81%)` | :arrow_down: | | [hera\_sim/visibilities/pyuvsim\_wrapper.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vdmlzaWJpbGl0aWVzL3B5dXZzaW1fd3JhcHBlci5weQ==) | `95.45% <100.00%> (-4.55%)` | :arrow_down: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/251/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.