search

HERA-Team / hera_sim

Simple simulation code for HERA-like redundant interferometric arrays
Other
16 stars 8 forks source link

ci: pin numpy in ci due to numba #254

Closed steven-murray closed 1 year ago

steven-murray commented 1 year ago

pyuvsim external tests of herasim were breaking, and it seems it's because the latest numpy (1.24) and some versions of numba are not compatible (see https://github.com/numba/numba/issues/8615). This pins numpy<1.24 until that problem is sorted out.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.51 :warning:

Comparison is base (d4bb723) 96.55% compared to head (fee6204) 96.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #254 +/- ## ========================================== - Coverage 96.55% 96.04% -0.51% ========================================== Files 24 23 -1 Lines 3046 2961 -85 ========================================== - Hits 2941 2844 -97 - Misses 105 117 +12 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `96.04% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_sim/adjustment.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vYWRqdXN0bWVudC5weQ==) | `100.00% <100.00%> (+0.76%)` | :arrow_up: | | [hera\_sim/antpos.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vYW50cG9zLnB5) | `100.00% <100.00%> (ø)` | | | [hera\_sim/beams.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vYmVhbXMucHk=) | `98.64% <100.00%> (+0.42%)` | :arrow_up: | | [hera\_sim/cli\_utils.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vY2xpX3V0aWxzLnB5) | `98.78% <100.00%> (ø)` | | | [hera\_sim/defaults.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vZGVmYXVsdHMucHk=) | `95.53% <100.00%> (ø)` | | | [hera\_sim/io.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vaW8ucHk=) | `98.59% <100.00%> (-0.04%)` | :arrow_down: | | [hera\_sim/sigchain.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vc2lnY2hhaW4ucHk=) | `97.98% <100.00%> (-0.50%)` | :arrow_down: | | [hera\_sim/simulate.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vc2ltdWxhdGUucHk=) | `94.73% <100.00%> (+<0.01%)` | :arrow_up: | | [hera\_sim/utils.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vdXRpbHMucHk=) | `94.08% <100.00%> (-3.00%)` | :arrow_down: | | [hera\_sim/visibilities/simulators.py](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9zaW0vdmlzaWJpbGl0aWVzL3NpbXVsYXRvcnMucHk=) | `78.82% <100.00%> (-6.65%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

steven-murray commented 1 year ago

@r-pascua I think this is ready to go. I'm not sure why the coverage is not picking up the calling of the jit_reshape_vis_xxx functions, because I know they are being run :/