search

HERA-Team / hera_sim

Simple simulation code for HERA-like redundant interferometric arrays
Other
16 stars 8 forks source link

Fix mutual coupling conjugation #268

Closed r-pascua closed 8 months ago

r-pascua commented 1 year ago

This PR fixes the conjugation error in the electric field propagator in the mutual coupling simulator. This should now ensure that the fringe-rate vs delay waterfalls for simulated coupling have the same shape as in the data.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

r-pascua commented 8 months ago

This took a long time to come around to, but I've finally made a decisive comparison of the coupling simulations against what we see in the data. The amplitude of the coupling is greater in the data than what is predicted by the simulation, but it looks like the shapes in fringe-rate vs delay space agree. I figured I would post the results here for reference.

Screenshot from 2024-01-17 19-57-11

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (35c472b) 92.92% compared to head (40b3491) 92.92%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #268 +/- ## ======================================= Coverage 92.92% 92.92% ======================================= Files 24 24 Lines 3223 3224 +1 Branches 705 705 ======================================= + Hits 2995 2996 +1 Misses 126 126 Partials 102 102 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/268/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_sim/pull/268/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `92.89% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.