search

HERA-Team / matvis

Fast matrix-based visibility simulator
MIT License
2 stars 3 forks source link

Better handling of coordinates #10

Closed philbull closed 3 years ago

philbull commented 3 years ago

This PR clarifies which coordinate systems are being assumed for the input variables (source position cosines crd_eq and time-dependent rotation matrices eq2tops), and fixes an ordering bug in a coordinate conversion for the non-pixel beam call.

codecov[bot] commented 3 years ago

Codecov Report

Merging #10 (f04e19f) into main (be9df1b) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   45.00%   45.00%           
=======================================
  Files           6        6           
  Lines         320      320           
  Branches       49       49           
=======================================
  Hits          144      144           
  Misses        162      162           
  Partials       14       14
Impacted Files Coverage Δ
src/vis_cpu/conversions.py 69.76% <ø> (ø)
src/vis_cpu/vis_cpu.py 80.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6e4cc6...f04e19f. Read the comment docs.