HERA-Team / matvis

Fast matrix-based visibility simulator
MIT License
2 stars 3 forks source link

refactor: rename vis_cpu to matvis #72

Closed piyanatk closed 11 months ago

piyanatk commented 11 months ago

This PR rename vis_cpu to matvis following the consensus from the paper. It will also require refactoring in hera_sim

review-notebook-app[bot] commented 11 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2bdfab8) 100.00% compared to head (1ecce4f) 100.00%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #72 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 8 8 Lines 567 566 -1 Branches 88 88 ========================================= - Hits 567 566 -1 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/matvis/pull/72/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/matvis/pull/72/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `99.29% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

steven-murray commented 11 months ago

I think the GPU tests are failing either because the enterprise server is still down, or because it doesn't have this GLIBC library. I think we need @mkolopanis help on that.