search

HERA-Team / uvtools

Tools useful for the handling, visualization, and analysis of interferometric data.
MIT License
1 stars 1 forks source link

make suppression factors and eigenval cutoff options optional. #131

Open aewallwi opened 3 years ago

aewallwi commented 3 years ago

Make the suppression_factors arg in dayenu_filter and _fit_basis_2d/1d optional and also pass tol as an optional arg to these functions. if supression_factors is not provided, then use tol to set the same suppression factors in all fourier windows specified in filter_centers and filter_half_widths.

Also make the eigenval_cutoff and other series termination args in dpss_operator optional. If no cutoff is provided, use a cutoff of 1e-12 for all filter_centers and filter_half_widths.

codecov[bot] commented 3 years ago

Codecov Report

Merging #131 (379f9ee) into main (551b0da) will decrease coverage by 0.33%. The diff coverage is 77.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   87.81%   87.48%   -0.34%     
==========================================
  Files           7        7              
  Lines        1502     1518      +16     
==========================================
+ Hits         1319     1328       +9     
- Misses        183      190       +7
Flag Coverage Δ
unittests 87.48% <77.41%> (-0.34%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
uvtools/dspec.py 97.00% <77.41%> (-0.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 551b0da...379f9ee. Read the comment docs.