Open piyanatk opened 5 years ago
Does it do anything specific to interferometry? It’s fine for now, but we might move it on later.
On Wed, Oct 30, 2019 at 2:13 AM Piyanat (Boom) Kittiwisit < notifications@github.com> wrote:
There is a plan to use automate.py from hera_stats to automatically execute and update step -1 validation notebooks (see HERA-Team/hera-validation#31 https://github.com/HERA-Team/hera-validation/issues/31), so the script should be hosted in a central location. After a discussion with @philbull https://github.com/philbull, we think that uvtools is the right place to host it. Is there any objection?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/HERA-Team/uvtools/issues/44?email_source=notifications&email_token=AAAPNVYIPSV2L5AN54UFB5LQRFF35A5CNFSM4JGV2DY2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HVKXEWA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPNVZCMQTA4A2XYCBY46DQRFF35ANCNFSM4JGV2DYQ .
-- Sent from Gmail Mobile
What will you be moving? The automation framework, or the specific notebook template itself?
@dannyjacobs Unfortunately, it does not have anything specific to do with interferometry. It is basically a Python module for automating tests with Jupyter notebooks. There are two functions in the module: one to execute a Jupyter notebook through a command line interface, and another one to automatically a new edited copy of the notebook when a certain criteria fail. So it does not fit with the current scope of uvtools
. But it seems over-killed to make a new repository to for it.
@steven-murray Just the automation framework, automate.py
and its test script test_automate.py
Lets keep it uvtools for now.
On Wed, Oct 30, 2019 at 11:41 AM Piyanat (Boom) Kittiwisit < notifications@github.com> wrote:
@dannyjacobs https://github.com/dannyjacobs Unfortunately, it does not have anything specific to do with interferometry. It is basically a Python module for automating tests with Jupyter notebooks. There are two functions in the module: one to execute a Jupyter notebook through a command line interface, and another one to automatically a new edited copy of the notebook when a certain criteria fail. So it does not fit with the current scope of uvtools. But it seems over-killed to make a new repository to for it.
@steven-murray https://github.com/steven-murray Just the automation framework, automate.py and its test script test_automate.py
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HERA-Team/uvtools/issues/44?email_source=notifications&email_token=AAAPNV5NRV7BAAQDHVMZIW3QRHIOPA5CNFSM4JGV2DY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECVLCIY#issuecomment-548057379, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPNV7MLBGBUWLWT7IQXFLQRHIOPANCNFSM4JGV2DYQ .
-- Arizona State University School of Earth and Space Exploration Low Frequency Cosmology Phone: (505) 500 4521 Homepage: danielcjacobs.com
I disagree that it seems overkill to make it a specialized repo. I think it makes perfect sense to do that if more than one repo depends on it.
uvtools is exactly that kind of repo. I also would like to see some coherent thought put into what else might go into an automation package.
I could be persuaded to make it separate as long as its maybe a little bit more general. There will be other things that fall into the category of "analysis testing".
On Mon, Nov 4, 2019 at 2:53 PM Steven Murray notifications@github.com wrote:
I disagree that it seems overkill to make it a specialized repo. I think it makes perfect sense to do that if more than one repo depends on it.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HERA-Team/uvtools/issues/44?email_source=notifications&email_token=AAAPNV35IXB2B3CMJTIMERTQSCKVPA5CNFSM4JGV2DY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDA3AOQ#issuecomment-549564474, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPNV3CGEQQJZQSTFZOOZLQSCKVPANCNFSM4JGV2DYQ .
-- Arizona State University School of Earth and Space Exploration Low Frequency Cosmology Phone: (505) 500 4521 Homepage: danielcjacobs.com
There is a plan to use
automate.py
fromhera_stats
to automatically execute and update step -1 validation notebooks (see https://github.com/HERA-Team/hera-validation/issues/31), so the script should be hosted in a central location. After a discussion with @philbull, we think thatuvtools
is the right place to host it. Is there any objection?