Closed aewallwi closed 4 years ago
Thank you @r-pascua for the quick review! I've added a 2d check. It passes on my computer so I think it's ready for another look but it looks like there are not issues with travis and basemap ( #93 ). Lets take care of this in a separate PR.
Ok, happy to approve since you say its passing locally. Definitely agree that the Basemap
issue should be handled in a different PR.
EDIT: Looks like we're not allowed to merge until the issue is fixed. So we'll need to get the Basemap
fix merged in before we can merge this.
small change to
dayenu_filter
that ensures that flagged data in the residual is equal to zero.