search

HERMES-SOC / hermes_instrument

A Python package template for hermes packages
Other
3 stars 4 forks source link

Coding standards violation #17

Open acrager opened 2 years ago

acrager commented 2 years ago

From Coding Standards, from packagename import * should never be used (except in __init__.py).

hermes_instrument/tests/test_calibration.py violates this policy on line 2.

ehsteve commented 2 years ago

Having thought about this a little bit longer, I think I can be convinced to keep this exception if we think it makes things easier. This file is only used in testing and our package should never include functions that have the same name.