HEROLABS / herolabs-apns

A small library to user with the Apple push notification service
24 stars 18 forks source link

Annoying debug logs #9

Open lbeschastny opened 10 years ago

lbeschastny commented 10 years ago

Hi.

Is there a good way to disable herolabs/apns debug logging?

I already tried:

But that didn't help.

chrisbetz commented 10 years ago

Hi,

as you may have noticed, we're using https://github.com/clojure/tools.logging for our logging purposes. Thus, it depends in your runtime dependencies, which logging framework really hits your console.

Pls check tools logging page for order oft frameworks and your used framework's doc for proper config. E.g. by setting your desired log level.

Sincerely,

Dr. Christian Betz

Am 18.09.2014 14:49 schrieb "Leonid Beschasny" notifications@github.com:

Hi.

Is there a good way to disable herolabs/apns debug logs?

I already tried:

setting clojure.tools.logging/tx-agent-levels to (constantly true) setting clojure.tools.logging/force to :agent wrapping all interactions with herolabs/apns with with-out-string macro

But that didn't help.

— Reply to this email directly or view it on GitHub.

lbeschastny commented 10 years ago

@chrisbetz I still believe that it's a herolabs/apns issue.

Having herolabs/apns in my classpath cause org.clojure/tools.logging to ignore all my logging settings, including:

Removing herolabs/apns solves all my logging problems.

lbeschastny commented 10 years ago

@chrisbetz I inspected your source and deps and found that the real troublemaker is

[ch.qos.logback/logback-core "1.0.13"]
lbeschastny commented 10 years ago

Probably, having logback-core in classpath force tools.logging to use it as a logging implementation.

lbeschastny commented 10 years ago

herolabs/apns is a library, why did you bind it with a specific logging implementation?

lbeschastny commented 10 years ago

Adding logback.xml helped, but you shouldn't force people to use Logback.

Please, remove it from herolabs/apns dependencies, or move to dev dependencies.