Closed psavery closed 11 months ago
Although this works, I found an issue with modifying eta_step
. Detectors that have a split in eta (i. e., contain -180
next to 180
) don't appear correct for smaller eta_step
values, such as 0.05
. I believe the issue is here
The problem is that for a detector split in eta, we need to remap the angles to be increasing with no gap. So, for instance, for dexelas, ff2
needs to go from 98.5
degrees to 261.5
degrees.
Something in the logic in that function is breaking for small eta_step
so that the eta values don't get ordered correctly, and that's making the histogram look wrong. We need to fix that issue.
@donald-e-boyce This is working now.
For reference, here are eta omega maps produced using different eta steps. A smaller eta step produces a higher resolution along the eta axis. The default eta value is 0.25, and that was hardcoded before this PR.
@donald-e-boyce I made your suggested changes and removed the histogramming entirely. It seems to work well! This is ready for your review.
Unfortunately, removing the histogramming appears to have changed two things:
np.nan
, but not after these changes (it is 0 instead)@donald-e-boyce helped me fix this.
The only potential issue is that, for a small eta step, there are some nans on the detector plates. However, indexing still worked fine. We will explore fixing this in the future, if needed.
It was previously fixed to 0.25 degrees. However, the users may find it beneficial to change this.
Smaller eta_step sizes might lead to less overlap between neighboring peaks in the eta omega maps, for example.