fixed bug in GrainData.load and added rotation_matrices attribute

HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.

Other

55 stars 26 forks source link

fixed bug in GrainData.load and added rotation_matrices attribute #589

Closed donald-e-boyce closed 8 months ago

donald-e-boyce commented 8 months ago

This fixes a bug in the load() method; the keyword arguments needed a "**" in front.

It also adds a method to compute the rotation matrices from the exponential map parameters. This is very useful since the orientations are always used as rotation matrices. This was motivated by the recent discussions of near field processing.

pep8speaks commented 8 months ago

Hello @donald-e-boyce! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tests/test_graindata.py:

Line 14:22: E231 missing whitespace after ','