search

HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.
Other
55 stars 26 forks source link

Check if compile args are being used by Windows #612

Closed psavery closed 6 days ago

psavery commented 7 months ago

These compile arguments are in a gcc-like format. But it looks like they are also being passed to the Visual Studio compiler. I have a feeling that Visual Studio might just be ignoring them. We should verify that Visual Studio is using these compiler arguments correctly.

kevindlewis23 commented 2 weeks ago

They are ignored, I saw this in the pip install output

  cl : Command line warning D9002 : ignoring unknown option '-O3'
  cl : Command line warning D9002 : ignoring unknown option '-shared'
  cl : Command line warning D9002 : ignoring unknown option '-std=c++14'
  cl : Command line warning D9002 : ignoring unknown option '-funroll-loops'
psavery commented 2 weeks ago

Yeah, I think we need to branch the logic for compiler options so Windows will only receive what it will actually use