Update nfutil.py - Githubissues

HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.

Other

54 stars 26 forks source link

Update nfutil.py #631

Open darrencpagan opened 3 months ago

darrencpagan commented 3 months ago

Small bug in the plot oris function where the rotations call hadn't been updated.

Also someone had changed the code to separate the confidence map plotting. This was not the intended use. The confidence map gets plotted over the top to darken regions of low confidence.

pep8speaks commented 3 months ago

Hello @darrencpagan! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file hexrd/grainmap/nfutil.py:

Line 1494:5: E265 block comment should start with '# ' Line 1496:5: E265 block comment should start with '# '

psavery commented 2 months ago

@darrencpagan Feel free to merge. That packaging failure was an issue that was recently fixed on master, so it shouldn't be an issue any longer.