search

HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.
Other
56 stars 25 forks source link

Eigen based anglesToGvec implementation #634

Closed ZackAttack614 closed 2 months ago

ZackAttack614 commented 5 months ago

Convert the C implementation of anglesToGvec to C++, using the Eigen library for optimized matrix performance.

Expected single-thread performance increase: 10%

Future improvements can be made by building and optimizing for different CPU architectures, using the march option at compile time.

pep8speaks commented 5 months ago

Hello @ZackAttack614! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 117:80: E501 line too long (89 > 79 characters)