search

HEXRD / hexrd

A cross-platform, open-source library for the analysis of X-ray diffraction data.
Other
54 stars 26 forks source link

Testcases #651

Open kevindlewis23 opened 3 weeks ago

kevindlewis23 commented 3 weeks ago

Adding test cases for transforms/xf_new_capi

pep8speaks commented 3 weeks ago

Hello @kevindlewis23! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-07-02 18:15:23 UTC
kevindlewis23 commented 3 weeks ago

Check NaN cases in gvec_to_xy. Whenever both gvecToDetectorXYArray and gvec_to_xy return something, they return the same thing. However, NaN's do not match up

psavery commented 3 weeks ago

Check NaN cases in gvec_to_xy. Whenever both gvecToDetectorXYArray and gvec_to_xy return something, they return the same thing. However, NaN's do not match up

That's unfortunate :slightly_frowning_face:. This is part of the reason it has taken some time to integrate these.